freecodecamp-quality-assurance/metric-imperial-converter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove tests from boilerplate (#14)

Browse Source 
* Remove tests from boilerplate

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Comment out NODE_ENV

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
This commit is contained in:
Nicholas Carrigan (he/him) 2021-03-12 08:39:21 -08:00 committed by GitHub
parent b8dcd60fbc
commit 7fab5e7fd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 1 additions and 197 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
controllers/convertHandler.js
View File

@ -1,11 +1,3 @@
/*
*
*
* Complete the handler logic below
*
*
*/
function ConvertHandler() { function ConvertHandler() {
this.getNum = function(input) { this.getNum = function(input) {

20
routes/api.js
View File

@ -1,11 +1,3 @@
/*
*
*
* Complete the API routing below
*
*
*/
'use strict'; 'use strict';
const expect = require('chai').expect; const expect = require('chai').expect;
@ -15,16 +7,4 @@ module.exports = function (app) {
let convertHandler = new ConvertHandler(); let convertHandler = new ConvertHandler();
app.route('/api/convert')
.get(function (req, res){
let input = req.query.input;
let initNum = convertHandler.getNum(input);
let initUnit = convertHandler.getUnit(input);
let returnNum = convertHandler.convert(initNum, initUnit);
let returnUnit = convertHandler.getReturnUnit(initUnit);
let toString = convertHandler.getString(initNum, initUnit, returnNum, returnUnit);
//res.json
});
}; };

2
sample.env
View File

@ -1,2 +1,2 @@
PORT= PORT=
NODE_ENV=test # NODE_ENV=test

118
tests/1_unit-tests.js
View File

@ -1,11 +1,3 @@
/*
*
*
* FILL IN EACH UNIT TEST BELOW COMPLETELY
* -----[Keep the tests in the same order!]----
* (if additional are added, keep them at the very end!)
*/
const chai = require('chai'); const chai = require('chai');
let assert = chai.assert; let assert = chai.assert;
const ConvertHandler = require('../controllers/convertHandler.js'); const ConvertHandler = require('../controllers/convertHandler.js');
@ -13,115 +5,5 @@ const ConvertHandler = require('../controllers/convertHandler.js');
let convertHandler = new ConvertHandler(); let convertHandler = new ConvertHandler();
suite('Unit Tests', function(){ suite('Unit Tests', function(){
suite('Function convertHandler.getNum(input)', function() {
test('Whole number input', function(done) {
let input = '32L';
assert.equal(convertHandler.getNum(input),32);
done();
});
test('Decimal Input', function(done) {
//done();
});
test('Fractional Input', function(done) {
//done();
});
test('Fractional Input w/ Decimal', function(done) {
//done();
});
test('Invalid Input (double fraction)', function(done) {
//done();
});
test('No Numerical Input', function(done) {
//done();
});
});
suite('Function convertHandler.getUnit(input)', function() {
test('For Each Valid Unit Inputs', function(done) {
let input = ['gal','l','mi','km','lbs','kg','GAL','L','MI','KM','LBS','KG'];
input.forEach(function(ele) {
//assert
});
done();
});
test('Unknown Unit Input', function(done) {
//done();
});
});
suite('Function convertHandler.getReturnUnit(initUnit)', function() {
test('For Each Valid Unit Inputs', function(done) {
let input = ['gal','l','mi','km','lbs','kg'];
let expect = ['L','gal','km','mi','kg','lbs'];
input.forEach(function(ele, i) {
assert.equal(convertHandler.getReturnUnit(ele), expect[i]);
});
done();
});
});
suite('Function convertHandler.spellOutUnit(unit)', function() {
test('For Each Valid Unit Inputs', function(done) {
//see above example for hint
done();
});
});
suite('Function convertHandler.convert(num, unit)', function() {
test('Gal to L', function(done) {
let input = [5, 'gal'];
let expected = 18.9271;
assert.approximately(convertHandler.convert(input[0],input[1]),expected,0.1); //0.1 tolerance
done();
});
test('L to Gal', function(done) {
//done();
});
test('Mi to Km', function(done) {
//done();
});
test('Km to Mi', function(done) {
//done();
});
test('Lbs to Kg', function(done) {
//done();
});
test('Kg to Lbs', function(done) {
//done();
});
});
}); });

50
tests/2_functional-tests.js
View File

@ -1,11 +1,3 @@
/*
*
*
* FILL IN EACH FUNCTIONAL TEST BELOW COMPLETELY
* -----[Keep the tests in the same order!]-----
* (if additional are added, keep them at the very end!)
*/
const chaiHttp = require('chai-http'); const chaiHttp = require('chai-http');
const chai = require('chai'); const chai = require('chai');
let assert = chai.assert; let assert = chai.assert;
@ -15,46 +7,4 @@ chai.use(chaiHttp);
suite('Functional Tests', function() { suite('Functional Tests', function() {
suite('Routing Tests', function() {
suite('GET /api/convert => conversion object', function() {
test('Convert 10L (valid input)', function(done) {
chai.request(server)
.get('/api/convert')
.query({input: '10L'})
.end(function(err, res){
assert.equal(res.status, 200);
assert.equal(res.body.initNum, 10);
assert.equal(res.body.initUnit, 'l');
assert.approximately(res.body.returnNum, 2.64172, 0.1);
assert.equal(res.body.returnUnit, 'gal');
done();
});
});
test('Convert 32g (invalid input unit)', function(done) {
//done();
});
test('Convert 3/7.2/4kg (invalid number)', function(done) {
//done();
});
test('Convert 3/7.2/4kilomegagram (invalid number and unit)', function(done) {
//done();
});
test('Convert kg (no number)', function(done) {
//done();
});
});
});
}); });