freecodecamp-quality-assurance/metric-imperial-converter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix (Boilerplate): Add Event Parameter to test, Remove Infosec Requriements, Add Lowercase Requirement (#12)

Browse Source 
* Fix missing event, correct example conversion

* Fix unit case

* Remove Infosec items, add lowercase requirement

* Convert to ES6, Update Packages, Fix display

* Applying @nhcarrigan's changes from site tests

* Removed unneeded mongodb ref

* Remove User Stories, Reformat README

* Apply suggestions from code review - Remove "Quality Assurance Project" Prefix

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Re-add the example text, clean up formatting

* Update Favicon

* Fix repo link, remove zombie.js

* Remove unused files, add sample.env

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Rex Schrader <rex.schader@gmail.com>
This commit is contained in:
Rex Schrader
2020-11-25 07:09:04 -08:00
committed by GitHub
parent 14cd901870
commit 87ebc9c36a
18 changed files with 1085 additions and 1158 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/1_unit-tests.js
+10 -10
View File
@@ -6,18 +6,18 @@
* (if additional are added, keep them at the very end!)
*/
var chai = require('chai');
var assert = chai.assert;
var ConvertHandler = require('../controllers/convertHandler.js');
const chai = require('chai');
let assert = chai.assert;
const ConvertHandler = require('../controllers/convertHandler.js');
var convertHandler = new ConvertHandler();
let convertHandler = new ConvertHandler();
suite('Unit Tests', function(){
suite('Function convertHandler.getNum(input)', function() {
test('Whole number input', function(done) {
var input = '32L';
let input = '32L';
assert.equal(convertHandler.getNum(input),32);
done();
});
@@ -52,7 +52,7 @@ suite('Unit Tests', function(){
suite('Function convertHandler.getUnit(input)', function() {
test('For Each Valid Unit Inputs', function(done) {
var input = ['gal','l','mi','km','lbs','kg','GAL','L','MI','KM','LBS','KG'];
let input = ['gal','l','mi','km','lbs','kg','GAL','L','MI','KM','LBS','KG'];
input.forEach(function(ele) {
//assert
});
@@ -69,8 +69,8 @@ suite('Unit Tests', function(){
suite('Function convertHandler.getReturnUnit(initUnit)', function() {
test('For Each Valid Unit Inputs', function(done) {
var input = ['gal','l','mi','km','lbs','kg'];
var expect = ['l','gal','km','mi','kg','lbs'];
let input = ['gal','l','mi','km','lbs','kg'];
let expect = ['L','gal','km','mi','kg','lbs'];
input.forEach(function(ele, i) {
assert.equal(convertHandler.getReturnUnit(ele), expect[i]);
});
@@ -91,8 +91,8 @@ suite('Unit Tests', function(){
suite('Function convertHandler.convert(num, unit)', function() {
test('Gal to L', function(done) {
var input = [5, 'gal'];
var expected = 18.9271;
let input = [5, 'gal'];
let expected = 18.9271;
assert.approximately(convertHandler.convert(input[0],input[1]),expected,0.1); //0.1 tolerance
done();
});
tests/2_functional-tests.js
+5 -5
View File
@@ -6,10 +6,10 @@
* (if additional are added, keep them at the very end!)
*/
var chaiHttp = require('chai-http');
var chai = require('chai');
var assert = chai.assert;
var server = require('../server');
const chaiHttp = require('chai-http');
const chai = require('chai');
let assert = chai.assert;
const server = require('../server');
chai.use(chaiHttp);
@@ -26,7 +26,7 @@ suite('Functional Tests', function() {
.end(function(err, res){
assert.equal(res.status, 200);
assert.equal(res.body.initNum, 10);
assert.equal(res.body.initUnit, 'L');
assert.equal(res.body.initUnit, 'l');
assert.approximately(res.body.returnNum, 2.64172, 0.1);
assert.equal(res.body.returnUnit, 'gal');
done();