sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Proper deprecation of Palette.popdown state argument

Browse Source 
The popdown state argument was removed in 90cec5b, as the palette
popdowns were unified.  However, this is a public api.  Removing
the argument caused exceptions to be raised, breaking applications.
Most uses of the state argument were for the SECONDARY state, which
is now the default behaviour.

This commit re-adds the argument with a deprecation notice.
This commit is contained in:
Sam Parkinson 2016-08-14 21:46:31 +10:00
parent 1f7937749c
commit 2330ef8ebc
No known key found for this signature in database
GPG Key ID: 34E268B2FA2F8B13
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sugar3/graphics/palette.py
View File

@ -223,7 +223,19 @@ class Palette(PaletteWindow):
PaletteWindow.popup(self, immediate) PaletteWindow.popup(self, immediate)
def popdown(self, immediate=False): def popdown(self, immediate=False, state=None):
'''
Popdown (or show the full contents of) the palette.
Keyword Args:
immediate (bool): if True, the palette will be shown instantly (as
if the user right clicked the item). If False, the palette
will be shown after the usual activation wait time.
.. deprecated:: 0.109
The state keyword argument is deprecated. The old
secondary state has become the only state.
'''
if immediate: if immediate:
if self._widget: if self._widget:
self._widget.size_request() self._widget.size_request()