sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BundleBuilder: Don't crash on malformed translation files

Browse Source 
The BundleBuilder currently crashes on a malformed translation file.  This is
good for humans (makes them fix their issues) but crashes bots who need it
compiled and don't care about that single translation file.

This patch adds a --no-fail option which stops the builder from crashing
This commit is contained in:
Sam Parkinson 2014-11-22 07:39:31 +11:00 committed by Gonzalo Odiard
parent b78989b755
commit 712682a3b0
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sugar3/activity/bundlebuilder.py
View File

@ -103,8 +103,9 @@ class Config(object):
class Builder(object): class Builder(object):
def __init__(self, config): def __init__(self, config, no_fail=False):
self.config = config self.config = config
self._no_fail = no_fail
self.locale_dir = os.path.join(self.config.build_dir, 'locale') self.locale_dir = os.path.join(self.config.build_dir, 'locale')
def build(self): def build(self):
@ -137,6 +138,8 @@ class Builder(object):
retcode = subprocess.call(args) retcode = subprocess.call(args)
if retcode: if retcode:
print 'ERROR - msgfmt failed with return code %i.' % retcode print 'ERROR - msgfmt failed with return code %i.' % retcode
if self._no_fail:
continue
cat = gettext.GNUTranslations(open(mo_file, 'r')) cat = gettext.GNUTranslations(open(mo_file, 'r'))
translated_name = cat.gettext(self.config.activity_name) translated_name = cat.gettext(self.config.activity_name)
@ -329,7 +332,7 @@ def cmd_dev(config, options):
def cmd_dist_xo(config, options): def cmd_dist_xo(config, options):
"""Create a xo bundle package""" """Create a xo bundle package"""
packager = XOPackager(Builder(config)) packager = XOPackager(Builder(config, options.no_fail))
packager.package() packager.package()
@ -427,7 +430,12 @@ def start():
default=1, nargs='?', default=1, nargs='?',
help="verbosity for the unit tests") help="verbosity for the unit tests")
subparsers.add_parser("dist_xo", help="Create a xo bundle package") dist_parser = subparsers.add_parser("dist_xo",
help="Create a xo bundle package")
dist_parser.add_argument("--no-fail", dest="no_fail", action="store_true",
default=False,
help="continue past failure when building xo file")
subparsers.add_parser("dist_source", help="Create a tar source package") subparsers.add_parser("dist_source", help="Create a tar source package")
subparsers.add_parser("build", help="Build generated files") subparsers.add_parser("build", help="Build generated files")
subparsers.add_parser( subparsers.add_parser(