Bug 590# fixed (codestyle issues)
This commit is contained in:
parent
76d3e78302
commit
7b4333dc4e
@ -115,39 +115,45 @@ def start(module_id):
|
|||||||
|
|
||||||
def cleanup():
|
def cleanup():
|
||||||
logs_dir = _get_logs_dir()
|
logs_dir = _get_logs_dir()
|
||||||
|
|
||||||
#---------------------------------------------------------
|
|
||||||
# Configure logfile backups
|
|
||||||
#---------------------------------------------------------
|
|
||||||
# File extension for backed up logfiles.
|
# File extension for backed up logfiles.
|
||||||
file_suffix = int( time.time() )
|
|
||||||
|
file_suffix = int(time.time())
|
||||||
|
|
||||||
# Absolute directory path where to store old logfiles.
|
# Absolute directory path where to store old logfiles.
|
||||||
# It will be created recursivly if it's not present.
|
# It will be created recursivly if it's not present.
|
||||||
|
|
||||||
backup_dirpath = os.path.join(logs_dir, 'old')
|
backup_dirpath = os.path.join(logs_dir, 'old')
|
||||||
|
|
||||||
# How many versions shall be backed up of every logfile?
|
# How many versions shall be backed up of every logfile?
|
||||||
|
|
||||||
num_backup_versions = 4
|
num_backup_versions = 4
|
||||||
#---------------------------------------------------------
|
|
||||||
|
|
||||||
# Make sure the backup location for old log files exists
|
# Make sure the backup location for old log files exists
|
||||||
|
|
||||||
if not os.path.exists(backup_dirpath):
|
if not os.path.exists(backup_dirpath):
|
||||||
os.makedirs(backup_dirpath)
|
os.makedirs(backup_dirpath)
|
||||||
|
|
||||||
# Iterate over every item in 'logs' directory
|
# Iterate over every item in 'logs' directory
|
||||||
|
|
||||||
for filename in os.listdir(logs_dir):
|
for filename in os.listdir(logs_dir):
|
||||||
|
|
||||||
old_filepath = os.path.join(logs_dir, filename)
|
old_filepath = os.path.join(logs_dir, filename)
|
||||||
|
|
||||||
if os.path.isfile(old_filepath):
|
if os.path.isfile(old_filepath):
|
||||||
|
|
||||||
# Backup every file
|
# Backup every file
|
||||||
|
|
||||||
new_filename = filename + '.' + str(file_suffix)
|
new_filename = filename + '.' + str(file_suffix)
|
||||||
new_filepath = os.path.join(backup_dirpath, new_filename)
|
new_filepath = os.path.join(backup_dirpath, new_filename)
|
||||||
os.rename(old_filepath, new_filepath)
|
os.rename(old_filepath, new_filepath)
|
||||||
|
|
||||||
backup_map = {}
|
|
||||||
|
|
||||||
# Tempoarily map all backup logfiles
|
# Tempoarily map all backup logfiles
|
||||||
|
|
||||||
for filename in os.listdir(backup_dirpath):
|
for filename in os.listdir(backup_dirpath):
|
||||||
|
|
||||||
# Remove the 'file_suffix' from the filename.
|
# Remove the 'file_suffix' from the filename.
|
||||||
|
|
||||||
end = filename.rfind(".")
|
end = filename.rfind(".")
|
||||||
key = filename[0:end].lower()
|
key = filename[0:end].lower()
|
||||||
key = key.replace(".", "_")
|
key = key.replace(".", "_")
|
||||||
@ -159,10 +165,9 @@ def cleanup():
|
|||||||
|
|
||||||
backup_list.append( os.path.join(backup_dirpath, filename) )
|
backup_list.append( os.path.join(backup_dirpath, filename) )
|
||||||
|
|
||||||
print backup_map
|
|
||||||
|
|
||||||
# Only keep 'num_backup_versions' versions of every logfile.
|
# Only keep 'num_backup_versions' versions of every logfile.
|
||||||
# Remove the others.
|
# Remove the others.
|
||||||
|
|
||||||
for key in backup_map:
|
for key in backup_map:
|
||||||
backup_list = backup_map[key]
|
backup_list = backup_map[key]
|
||||||
backup_list.sort()
|
backup_list.sort()
|
||||||
@ -170,4 +175,4 @@ def cleanup():
|
|||||||
|
|
||||||
for i in range(num_backup_versions, len(backup_list)):
|
for i in range(num_backup_versions, len(backup_list)):
|
||||||
os.remove(backup_list[i])
|
os.remove(backup_list[i])
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user