From a07bef8be59593db18cc89b2420945b324a160b0 Mon Sep 17 00:00:00 2001 From: Pro-Panda Date: Sat, 3 Mar 2018 12:58:49 +0530 Subject: [PATCH] Change signal name on enter keypress in title entry - 'enter-key-press' is more intuitive for the reader than 'entered' --- src/sugar3/activity/widgets.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sugar3/activity/widgets.py b/src/sugar3/activity/widgets.py index c8528358..06606e80 100644 --- a/src/sugar3/activity/widgets.py +++ b/src/sugar3/activity/widgets.py @@ -72,7 +72,7 @@ class ActivityToolbarButton(ToolbarButton): def __init__(self, activity, **kwargs): toolbar = ActivityToolbar(activity, orientation_left=True) - toolbar.connect('entered', lambda widget: self.emit('clicked')) + toolbar.connect('enter-key-press', lambda widget: self.emit('clicked')) ToolbarButton.__init__(self, page=toolbar, **kwargs) @@ -170,7 +170,7 @@ class ShareButton(RadioMenuButton): class TitleEntry(Gtk.ToolItem): __gsignals__ = { - 'entered': (GObject.SignalFlags.RUN_FIRST, None, ([])), + 'enter-key-press': (GObject.SignalFlags.RUN_FIRST, None, ([])), } def __init__(self, activity, **kwargs): @@ -195,7 +195,7 @@ class TitleEntry(Gtk.ToolItem): entry.select_region(0, 0) entry.hide() entry.show() - self.emit('entered') + self.emit('enter-key-press') return False def modify_bg(self, state, color): @@ -327,7 +327,7 @@ class DescriptionItem(ToolButton): class ActivityToolbar(Gtk.Toolbar): """The Activity toolbar with the Journal entry title and sharing button""" __gsignals__ = { - 'entered': (GObject.SignalFlags.RUN_FIRST, None, ([])), + 'enter-key-press': (GObject.SignalFlags.RUN_FIRST, None, ([])), } def __init__(self, activity, orientation_left=False): @@ -337,7 +337,7 @@ class ActivityToolbar(Gtk.Toolbar): if activity.metadata: title_button = TitleEntry(activity) - title_button.connect('entered', lambda widget: self.emit('entered')) + title_button.connect('enter-key-press', lambda widget: self.emit('enter-key-press')) title_button.show() self.insert(title_button, -1) self.title = title_button.entry