sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Activity.get_preview fails for no window in canvas

Browse Source 
When an activity deletes the window associated with the canvas, save may
fail because Gdk.cairo_create is given an argument of None.  Activity
continues to run without a window.

Reproduced with Chat activity and pressing Stop.

Avoid exception by returning None from get_preview when there is no
window.
This commit is contained in:
James Cameron 2018-01-02 14:15:15 +11:00
parent e13c4fefab
commit a77ae5fb57
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/sugar3/activity/activity.py
View File

@ -852,6 +852,9 @@ class Activity(Window, Gtk.Container):
return None return None
window = self.canvas.get_window() window = self.canvas.get_window()
if window is None:
return None
alloc = self.canvas.get_allocation() alloc = self.canvas.get_allocation()
dummy_cr = Gdk.cairo_create(window) dummy_cr = Gdk.cairo_create(window)