sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Save As - document keep failure

Browse Source 
- add a comment to explain the causes of keep failure,

- rename the keep failure response callback to fit convention,

- fix typo and whitespace nearby.
This commit is contained in:
James Cameron 2017-06-01 13:10:55 +10:00
parent 286387b22e
commit b1d1129759
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/sugar3/activity/activity.py
View File

@ -454,7 +454,7 @@ class Activity(Window, Gtk.Container):
def _initialize_journal_object(self): def _initialize_journal_object(self):
title = _('%s Activity') % get_bundle_name() title = _('%s Activity') % get_bundle_name()
icon_color = get_color().to_string() icon_color = get_color().to_string()
jobject = datastore.create() jobject = datastore.create()
@ -851,7 +851,7 @@ class Activity(Window, Gtk.Container):
This method is called by the close() method below. In general, This method is called by the close() method below. In general,
activities should not override this method. This method is part of the activities should not override this method. This method is part of the
public API of an Acivity, and should behave in standard ways. Use your public API of an Activity, and should behave in standard ways. Use your
own implementation of write_file() to save your Activity specific data. own implementation of write_file() to save your Activity specific data.
''' '''
@ -1048,6 +1048,11 @@ class Activity(Window, Gtk.Container):
pservice.share_activity(self, private=private) pservice.share_activity(self, private=private)
def _show_keep_failed_dialog(self): def _show_keep_failed_dialog(self):
'''
A keep error means the activity write_file method raised an
exception before writing the file, or the datastore cannot be
written to.
'''
alert = Alert() alert = Alert()
alert.props.title = _('Keep error') alert.props.title = _('Keep error')
alert.props.msg = _('Keep error: all changes will be lost') alert.props.msg = _('Keep error: all changes will be lost')
@ -1060,11 +1065,11 @@ class Activity(Window, Gtk.Container):
alert.add_button(Gtk.ResponseType.OK, _('Stop anyway'), stop_icon) alert.add_button(Gtk.ResponseType.OK, _('Stop anyway'), stop_icon)
self.add_alert(alert) self.add_alert(alert)
alert.connect('response', self._keep_failed_dialog_response_cb) alert.connect('response', self.__keep_failed_dialog_response_cb)
self.reveal() self.reveal()
def _keep_failed_dialog_response_cb(self, alert, response_id): def __keep_failed_dialog_response_cb(self, alert, response_id):
self.remove_alert(alert) self.remove_alert(alert)
if response_id == Gtk.ResponseType.OK: if response_id == Gtk.ResponseType.OK:
self.close(skip_save=True) self.close(skip_save=True)