sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Ensure logs path exists when initializing logs

Browse Source 
Otherwise, for example, if we start datastore alone
like we do in the tests, we try to create logs without
the directory and traceback.
This commit is contained in:
Daniel Narvaez 2013-10-07 23:31:49 +02:00
parent 2d33c92299
commit cf392735a0
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/sugar3/logger.py
View File

@ -118,6 +118,13 @@ def cleanup():
def start(log_filename=None): def start(log_filename=None):
logs_path = env.get_logs_path()
try:
os.makedirs(logs_path)
except OSError:
pass
# remove existing handlers, or logging.basicConfig() won't have no effect. # remove existing handlers, or logging.basicConfig() won't have no effect.
root_logger = logging.getLogger('') root_logger = logging.getLogger('')
for handler in root_logger.handlers: for handler in root_logger.handlers:
@ -156,7 +163,7 @@ def start(log_filename=None):
if log_filename: if log_filename:
try: try:
log_path = os.path.join(get_logs_dir(), log_filename + '.log') log_path = os.path.join(logs_path, log_filename + '.log')
log_fd = os.open(log_path, os.O_WRONLY | os.O_CREAT) log_fd = os.open(log_path, os.O_WRONLY | os.O_CREAT)
os.dup2(log_fd, sys.stdout.fileno()) os.dup2(log_fd, sys.stdout.fileno())