From cfb054124936cd8256703ed172a9417b7fe3811e Mon Sep 17 00:00:00 2001 From: Morgan Collett Date: Tue, 21 Aug 2007 11:39:05 +0100 Subject: [PATCH] Clean up leave() and callbacks --- sugar/presence/activity.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sugar/presence/activity.py b/sugar/presence/activity.py index 2df8793d..bdfc74f5 100644 --- a/sugar/presence/activity.py +++ b/sugar/presence/activity.py @@ -167,16 +167,17 @@ class Activity(gobject.GObject): return bus_name, connection, channels def _leave_cb(self): - # XXX Is this the right thing to do? + """Callback for async action of leaving shared activity.""" self.emit("joined", False, "left activity") def _leave_error_cb(self, err): - # XXX We are closing down anyway + """Callback for error in async leaving of shared activity. + + XXX Add logging!""" pass def leave(self): """Leave this shared activity""" - # FIXME self._joined = False self._activity.Leave(reply_handler=self._leave_cb, error_handler=self._leave_error_cb)