sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cache handle-buddies so we can get them when the buddy has already left

Browse Source
This commit is contained in:
Morgan Collett 2007-10-03 20:39:07 +01:00
parent c9908a6d27
commit f1df5361e1
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
sugar/presence/activity.py
View File

@ -90,6 +90,8 @@ class Activity(gobject.GObject):
self._tags = None self._tags = None
self._private = True self._private = True
self._joined = False self._joined = False
# Cache for get_buddy_by_handle
self._handle_to_buddy = {}
def _get_properties_reply_cb(self, new_props): def _get_properties_reply_cb(self, new_props):
self._properties_changed_cb(new_props) self._properties_changed_cb(new_props)
@ -215,12 +217,24 @@ class Activity(gobject.GObject):
return buddies return buddies
def get_buddy_by_handle(self, handle): def get_buddy_by_handle(self, handle):
"""Retrieve the Buddy object given a telepathy handle.""" """Retrieve the Buddy object given a telepathy handle.
buddyhandle = self._activity.GetBuddyByHandle(handle)
if buddyhandle: buddies are cached in self._handle_to_buddy, so we can
buddy = self._ps_new_object(buddyhandle) still get the buddy after they have left the activity.
else: """
buddy = None buddy = self._handle_to_buddy.get(handle, None)
if not buddy:
try:
buddyhandle = self._activity.GetBuddyByHandle(handle)
except:
# FIXME: Need to catch NotFoundError but that's defined
# in presence-service psutils
buddyhandle = None
if buddyhandle:
buddy = self._ps_new_object(buddyhandle)
self._handle_to_buddy[handle] = buddy
else:
buddy = None
return buddy return buddy
def invite(self, buddy, message, response_cb): def invite(self, buddy, message, response_cb):