sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removes the use of O_SYNC on logs #1656

Browse Source 
With O_SYNC on open of log files, on systems with slow filesystem random
write performance, there is random activity startup time.
This commit is contained in:
James Cameron 2010-03-09 09:29:30 +11:00 committed by Simon Schampijer
parent 6921bcd67d
commit f8ef93bd21
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/sugar/activity/activityfactory.py
View File

@ -149,8 +149,7 @@ def open_log_file(activity):
while True: while True:
path = env.get_logs_path('%s-%s.log' % (activity.get_bundle_id(), i)) path = env.get_logs_path('%s-%s.log' % (activity.get_bundle_id(), i))
try: try:
fd = os.open(path, os.O_EXCL | os.O_CREAT \ fd = os.open(path, os.O_EXCL | os.O_CREAT | os.O_WRONLY, 0644)
| os.O_SYNC | os.O_WRONLY, 0644)
f = os.fdopen(fd, 'w', 0) f = os.fdopen(fd, 'w', 0)
return (path, f) return (path, f)
except OSError, e: except OSError, e: