Commit Graph

23 Commits

Author SHA1 Message Date
Sascha Silbe
0521234fec CellRendererInvoker._redraw_path(): assure column is defined
We know that our code is correct and column should always be assigned, but it
never hurts to act defensively and guard against bugs in other pieces of the
code (or other components like GTK).

Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:36 +01:00
Sascha Silbe
05fd5fe2d7 ToolInvoker._get_alignments: fix missing self parameter
Caught by pylint. I wonder if we need this piece of code as nobody every
triggered it.

Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:36 +01:00
Sascha Silbe
7983242f7a pylint cleanup: initialise all attributes in __init__()
Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:36 +01:00
Sascha Silbe
7acfbd070f style cleanup: prefer ' for strings
Tomeu prefers ' for strings, so let's use it wherever we don't have a good
reason to use ".

Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:34 +01:00
Sascha Silbe
60707443ea PEP8 cleanup: fix whitespace around operator
Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:33 +01:00
Sascha Silbe
e2231d5620 PEP8 cleanup: fix number of blank lines
Caught by pep8.

Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
CC: Aleksey Lim <alsroot@member.fsf.org>
2010-11-23 17:14:32 +01:00
Tomeu Vizoso
29582de67f Add 'cache-palette' property to Invoker #1742
Meaning that the palette will be cached after it's created.
2010-10-14 19:06:31 +02:00
Simon Schampijer
abda2edc04 Remove unneeded debug logs #1861 2010-07-07 11:08:59 +02:00
Benjamin Berg
c684950ecf Do not emit the row-changed signal, but redraw the row for prelight.
This basically undos commit 4bb221349c
and fixes the code that was there before. Emitting the row-changed
signal causes any editing to be canceled.
2009-09-10 17:34:56 +02:00
Aleksey Lim
cdd4ba3a3d Palette will fail to open if you have just 'scrubbed' over some number of icons quickly #1312 2009-09-10 09:07:25 +00:00
Aleksey Lim
868c9293ac Hide palette group before immediate popup #1291 2009-09-10 07:48:20 +00:00
Aleksey Lim
ff2dd6cc0e Stop all animators on poup/popdown invoking #1310 2009-09-09 16:38:52 +00:00
Aleksey Lim
6b992ee9fb Close previous palette on reseting palette property in invoker #1299 2009-09-08 07:14:22 +00:00
Aleksey Lim
cb5951d3b9 Do not fail on immediate second palette openning for bottom icons #1292 2009-09-07 14:49:21 +00:00
Aleksey Lim
e97dd135eb Wrong calculated positions for palettes #1268 2009-09-04 17:02:57 +00:00
Aleksey Lim
2b78463830 Primary palette redraw glitch after secondary palette exposed #1135 2009-09-04 17:02:46 +00:00
Aleksey Lim
135b2a608d Hide all animators while deleting palettes #1265 2009-09-04 16:54:50 +00:00
Sascha Silbe
c9e63eb8ea PEP8 white space and long line fixes 2009-08-25 21:12:40 +02:00
Sascha Silbe
ecdaf6b795 trim EOL (end-of-line) spaces on source files 2009-08-25 19:55:48 +02:00
Simon Schampijer
e1e8647de9 pylint fixes 2009-08-24 14:51:00 +02:00
Sascha Silbe
496090fe62 let the logger do the formatting 2009-08-24 12:54:02 +02:00
Tomeu Vizoso
bdd760d92a Remove a couple of debug prints 2009-08-20 09:55:32 +02:00
Tomeu Vizoso
8f271e2604 Split PaletteWindow in its own module 2009-08-01 16:15:01 +02:00