sugarlabs/sugar-toolkit-gtk3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Change signal name on enter keypress in title entry

Browse Source 
- 'enter-key-press' is more intuitive for the reader than 'entered'
This commit is contained in:
Pro-Panda 2018-03-03 12:58:49 +05:30 committed by James Cameron
parent 1bc171d5d6
commit a07bef8be5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/sugar3/activity/widgets.py
View File

@ -72,7 +72,7 @@ class ActivityToolbarButton(ToolbarButton):
def __init__(self, activity, **kwargs): def __init__(self, activity, **kwargs):
toolbar = ActivityToolbar(activity, orientation_left=True) toolbar = ActivityToolbar(activity, orientation_left=True)
toolbar.connect('entered', lambda widget: self.emit('clicked')) toolbar.connect('enter-key-press', lambda widget: self.emit('clicked'))
ToolbarButton.__init__(self, page=toolbar, **kwargs) ToolbarButton.__init__(self, page=toolbar, **kwargs)
@ -170,7 +170,7 @@ class ShareButton(RadioMenuButton):
class TitleEntry(Gtk.ToolItem): class TitleEntry(Gtk.ToolItem):
__gsignals__ = { __gsignals__ = {
'entered': (GObject.SignalFlags.RUN_FIRST, None, ([])), 'enter-key-press': (GObject.SignalFlags.RUN_FIRST, None, ([])),
} }
def __init__(self, activity, **kwargs): def __init__(self, activity, **kwargs):
@ -195,7 +195,7 @@ class TitleEntry(Gtk.ToolItem):
entry.select_region(0, 0) entry.select_region(0, 0)
entry.hide() entry.hide()
entry.show() entry.show()
self.emit('entered') self.emit('enter-key-press')
return False return False
def modify_bg(self, state, color): def modify_bg(self, state, color):
@ -327,7 +327,7 @@ class DescriptionItem(ToolButton):
class ActivityToolbar(Gtk.Toolbar): class ActivityToolbar(Gtk.Toolbar):
"""The Activity toolbar with the Journal entry title and sharing button""" """The Activity toolbar with the Journal entry title and sharing button"""
__gsignals__ = { __gsignals__ = {
'entered': (GObject.SignalFlags.RUN_FIRST, None, ([])), 'enter-key-press': (GObject.SignalFlags.RUN_FIRST, None, ([])),
} }
def __init__(self, activity, orientation_left=False): def __init__(self, activity, orientation_left=False):
@ -337,7 +337,7 @@ class ActivityToolbar(Gtk.Toolbar):
if activity.metadata: if activity.metadata:
title_button = TitleEntry(activity) title_button = TitleEntry(activity)
title_button.connect('entered', lambda widget: self.emit('entered')) title_button.connect('enter-key-press', lambda widget: self.emit('enter-key-press'))
title_button.show() title_button.show()
self.insert(title_button, -1) self.insert(title_button, -1)
self.title = title_button.entry self.title = title_button.entry