This fixes a copy and paste error. A good test case is the Memorize
activity since we listen for the 'buddy-left' signal there to
update the members list inside the activity.
Signed-off-by: Simon Schampijer <[email protected]>
Acked-By: Sascha Silbe <[email protected]>
As a side effect, activity start-up is now subjectively faster, maybe even
objectively (due to avoiding a resize).
Tested on XO-1 running Debian Squeeze.
Acked-By: Simon Schampijer <[email protected]>
Before only the buddies that were present when closing the activity
were logged in the Journal. This patch does add another dictionary
'_joined_buddies' to keep track of the users that did join. The
'_buddies' dictionary keeps on tracking the users currently in the
activity.
Signed-off-by: Simon Schampijer <[email protected]>
Acked-by: Sascha Silbe <[email protected]>
GTK pops down the palette before it invokes the actions on the
menu item. We need to postpone destruction of the palette until
after all signals have propagated from the menu item to the
palette owner.
Symptoms included the "View Details" palette menu item in the Journal list
view not working.
Signed-off-by: Sascha Silbe <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
Remove the path parameter as it is not used anyhow. The patch
for the sugar module does make sure the method is called
correctly.
Signed-off-by: Gonzalo Odiard <[email protected]>
Acked-By: Simon Schampijer <[email protected]>
Reviewed-By: Sascha Silbe<[email protected]>
Allow the toolbar_box to be removed by setting it to None, like is supported
for canvas.
Signed-off-by: Sascha Silbe <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
sugar.bundle.bundle.Bundle users (e.g.
jarabe.model.bundleregistry.BundleRegistry._add_bundle) only expect
MalformedBundleException to be thrown, not exceptions of zipfile.
This patch solves the most severe issue in #1876: filling up the
filesystem with temporary files that won't be deleted afterwards.
Before we can consider this bug completely fixed, we still need
to do something for the remaining issues:
1) Unpacking shouldn't be attempted if there isn't a safety margin
2) System becomes unresponsive during unpacking
3) No progress indication for the operation, so users are tempted
to click multiple times
4) No error messages displayed for unpacking errors, which is a
common Sugar nuisance.
http://bugs.sugarlabs.org/ticket/1876#comment:5 offers possible
strategies for (1) and (2).
Signed-off-by: Martin Dengler <[email protected]>
Signed-off-by: Bernie Innocenti <[email protected]>
[style fixes, adjusted description]
Signed-off-by: Sascha Silbe <[email protected]>
Reviewed-by: Aleksey Lim <[email protected]>
Color data is stored in the Journal as a JSON dump, so we can get back
arbitrary types. XoColor already checks the color string for validity and
handles invalid strings gracefully, so it makes sense to enhance this to
invalid types as well.
Acked-by: Simon Schampijer <[email protected]>
As we do create the ActivityBundle in the config of the bundlebuilder
we can use the code from the activitybundle as well to install
the mime type.
Reviewed-By: Sascha Silbe <[email protected]>
pylint isn't smart enough to figure out the return type of Popen.communicate(),
so squelch the warning.
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
"format" is the name of a parameter of the function we are wrapping, so we
shouldn't change it.
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
We know that our code is correct and column should always be assigned, but it
never hurts to act defensively and guard against bugs in other pieces of the
code (or other components like GTK).
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
Caught by pylint. I wonder if we need this piece of code as nobody every
triggered it.
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
This avoids the overhead from the string formatting on production systems.
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
logging.exception() handles exceptions nicely for us, no need to explicitly
use traceback.
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
Tomeu prefers ' for strings, so let's use it wherever we don't have a good
reason to use ".
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
pep8 wants inline comments to be prefixed by at least two spaces. Let's just
move them to a separate line as that's easier to read anyway.
Acked-by: Simon Schampijer <[email protected]>
CC: Aleksey Lim <[email protected]>
Caught by PEP8. This is important for Sugar because the XO has a small screen
where long lines would make the code hard to understand (because you need to
constantly scroll horizontally).
Reviewed-by: James Cameron <[email protected]>
Acked-by: Simon Schampijer<[email protected]>
CC: Aleksey Lim <[email protected]>
- add class NormalizedVersion to parse and compare the new activity versions
- change the bundlebuilder and activitybundle to use the new scheme, instead
of an int version we expect a string that matches the format defined in
NormalizedVersion
* sugar/presence/presenceservice.py: Specify the D-Bus interface when
calling ActivityProperties.GetActivity
* sugar/activity/main.py: Set a default for the --invite option and
make the create() D-Bus method accept a{sv} so we can pass the
boolean value.