Commit Graph

5826 Commits

Author SHA1 Message Date
Martin Abente Lahaye
afd0737c10 Merge pull request #275 from quozl/2015-12-08-warnings
demote warning to debug for sugar_accel_group
2015-12-14 09:37:37 -03:00
James Cameron
a11639eb86 demote warning to debug for sugar_accel_group 2015-12-08 15:11:17 +11:00
James Cameron
280c74cd9e allow start on full disk
When disk is full, Sugar will not start, because the backup log
directory cannot be created.

X session logs in tmpfs show this exception:

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/jarabe/main.py", line 20, in <module>
    logger.cleanup()
  File "/usr/lib/python2.7/site-packages/sugar3/logger.py", line 113, in cleanup
    os.mkdir(backup_dir)
OSError: [Errno 28] No space left on device: '/home/user/.sugar/default/logs/1448258018'

Fix is to ignore the exception.

We've been here before!  Was previously fixed in 2010:

	https://github.com/sugarlabs/sugar/commit/4cde481
	https://bugs.sugarlabs.org/ticket/1720
	http://dev.laptop.org/ticket/9623

But new regression introduced in 2012 during reorganisation of
code by Daniel Narvaez; the exception was no longer handled:

	https://github.com/sugarlabs/sugar/commit/0e45f9d
	https://github.com/sugarlabs/sugar/commit/19db9c5

Reported-by: Nathan Riddle <nathanr333@charter.net>
Tested-by: James Cameron <quozl@laptop.org>
2015-11-23 17:26:29 +11:00
Sam Parkinson
ec7f723819 Merge branch '12813-g' of https://github.com/quozl/sugar-toolkit-gtk3 2015-10-31 14:10:33 +11:00
Martin Abente Lahaye
d8205de316 Release 0.107.0 2015-10-19 09:18:14 -03:00
James Cameron
0e724a78eb move guts of TimeoutAlert and NotifyAlert to a private class
Create a private class for the button, timeout and response.  Use the
private class as parent for both NotifyAlert and TimeoutAlert.

Extends the spurious response fix (cfeabdc) to NotifyAlert.

Also use g_timeout_add in preference to g_timeout_add_seconds, because
the latter is less precise in implementation.

Tested by changing the Register alert temporarily.
2015-10-16 14:06:51 +11:00
Sam Parkinson
d2e1793108 Merge branch '12813-e' of https://github.com/quozl/sugar-toolkit-gtk3 2015-10-15 21:35:13 +11:00
James Cameron
cfeabdc3af remove GSource used by TimeoutAlert
For an object of class TimeoutAlert, an OK response occurs on timeout,
even if user has clicked a button.

Remove the timeout when the user clicks a button.

A new method _response is added which overrides the parent method.
2015-10-15 11:17:41 +11:00
James Cameron
9de70acfff fix alerts documentation
- s/Set/Get for a get property method,

- fix two typos.
2015-10-15 11:12:02 +11:00
Ignacio Rodríguez
e16f8ec61b Merge pull request #255 from samdroid-apps/gtype-name-toolbarbox
Add gtype name to ToolbarBox for gtk css styling
2015-10-10 02:25:49 -03:00
Gonzalo Odiard
1bd8349b84 Deprecate create_jobject parameter on activity.py - Fixes #3450
As the ticket describe, create a object in the Journal
is no longer optional. The change do not break activities,
because the optional parameter is not removed, just ignored.
2015-10-05 00:41:21 -03:00
Sam Parkinson
f91da7b0f6 Add gtype name to ToolbarBox for gtk css styling 2015-09-09 18:18:15 +10:00
Gonzalo Odiard
7c804354a0 Improve documentation on activity module 2015-08-25 16:25:55 -03:00
Sam Parkinson
0bed21ccc8 Change graphics.alert docs to work well with Sphinx 2015-08-11 08:06:08 -03:00
Sam Parkinson
b9f19521fe Write docs for graphics.animator 2015-08-11 08:05:44 -03:00
Sam Parkinson
86762fb77a @samdroid-apps Add sphinx scripts and config to build documentaion 2015-08-11 08:05:15 -03:00
Gonzalo Odiard
84ad1b84cc Init the datastore on demand
Right now is not possible do "from sugar3.datastore import datastore"
outside of GLib loop, because the import try to connect to a DBus signal,
and throw a exception.

That was not a problem in Sugar, because we always have a Glib loop
on all our activities, but is a problem when we want import the classes
to generate docs with pydoc. Many other classes import datastore,
then this is a blocker.

This patch removes the initialization when imported,
will be done when needed.
2015-08-10 22:39:43 -03:00
Gonzalo Odiard
9314fd89fa Do not calculate palette height on PaletteWindowWidget - Fixes #4792
To solve ticket #4673, we calculate the palette size using the size
of all the widgets [2]. That solves the problem on Palettes based on
_PaletteMenuWidget but on _PaletteWindowWidget produce a wrong value
when the secondary_label is not null, and as a consequence
the palette position is wrong.
The solution is do the calculation only for _PaletteMenuWidget based
palettes.

[1] https://bugs.sugarlabs.org/ticket/4673
[2] b9d6b628a9
2015-08-07 12:58:07 -03:00
Sam Parkinson
e990ec7703 Merge branch 'activate_on_left_click_only' of https://github.com/godiard/sugar-toolkit-gtk3 2015-08-07 20:58:53 +10:00
Gonzalo Odiard
88213f6408 EventIcon: only trigger 'activate' signal on principal button click
With the introduction of 'activate' signal on [1], and the use of that
signal in Sugar Home, we introduced a bug, now, pressing the secondary button
starts the activity instead of open the palette.
This patch solves the issue checking the putton pressed before send the signal.

[1] a19cf9ed27
2015-08-06 16:59:13 -03:00
Gonzalo Odiard
100a6b56b6 Check if parameter 'options' is None in cmd_dist_xo
When is used to clone a activity from sugar,
the options parameter is set to None.
The other uses of no_fail have False as default value
but this case was missing.
The effect of this error is that a .xo is not created in the Journal,
when the user select 'Duplicate' in the View Source window.
2015-08-05 17:13:17 -03:00
Sam Parkinson
16107a3985 Show proper state indication for CanvasIcons
Commit a19cf9e changed the logic for handling CanvasIcon clicks.  Therefore,
the visual state indicators must be updated to fit the new logic.

Test Case:  Hold the mouse down on a home view icon.  Move the mouse
in and out of the icon.  See that the states correspond with what
happens if you release the mouse.
2015-08-04 11:58:06 -03:00
Sam Parkinson
ecc2f491b6 Merge branch 'fix_mousedetector_stop' of https://github.com/godiard/sugar-toolkit-gtk3 2015-07-26 09:32:02 +10:00
Gonzalo Odiard
fd15e76dab MouseDetector timeout_id need reset
The mouse detector have a variable to store the id for the timeout.
The stop() method check if the id is null but do not set the id to null
after remove the GObject timeout, then try to remove the timeout multiple times.

The efect can be seen if a user move the mouse slowly over the icons
in the Sugar home, in shell.log we see many lines like:

sugar3/graphics/palettewindow.py:443: Warning: Source ID 2464 was not found
when attempting to remove it
2015-07-24 15:07:09 -03:00
Gonzalo Odiard
a8e75af790 Check release mouse postion in CursorInvoker
This affect when a palette will be opened, by example in the BuddyIcon
in the Sugar home.
2015-07-24 12:00:02 -03:00
Gonzalo Odiard
a19cf9ed27 Do not trigger events on EventIcons when button release is outside - #4863
The industry convention for mouse driven menu options is for them
to be activated when two conditions are met:
* a button down event occurs with the pointer inside the option, and;
* a button up event occurs with the pointer inside the option.

This issue was already solved on the PaletteMenuItem,
but the EventIcon have the same problem. This change add a 'activate' event,
that control that the two conditions are meet.
The code in Sugar need use this event instead of button-release-event.
2015-07-24 11:40:49 -03:00
Sam Parkinson
9fc5b49329 Only activate menu items if the mouse releases in them - fixes #4863
Ticket URL <http://bugs.sugarlabs.org/ticket/4863>
2015-07-24 21:32:05 +10:00
Gonzalo Odiard
7a3d23e2b6 Don't add a label on RadioToolButton when set icon_widget - Fixes #4875
When we use set_icon_widget(), GtkToolButton set a private property
contents_invalid = TRUE [1], and gtk_tool_button_construct_content [2]
is called. Then if the label widget not exist, a GtkLabel is added.
This is a problem for us, by example in the Clipboard buttons in the frame.
By adding a empty Gtk.Box instead of a label, we avoid the label creation.

But as this is a internal implementation of Gtk, can change in the future,
in fact the issue is not visible with Gtk < 3.16

This patch is based in a pr sent by Sam Parkinson

[1] https://github.com/GNOME/gtk/blob/master/gtk/gtktoolbutton.c#L1415
[2] https://github.com/GNOME/gtk/blob/master/gtk/gtktoolbutton.c#L357
2015-07-08 14:25:47 -03:00
Martin Abente Lahaye
f215d20508 Release 0.106.0 2015-07-06 07:46:32 -04:00
Gonzalo Odiard
04d8f596bc Add get_bundle method to activity.py
When a programmer need open one activity from other [1]
usually need display in the user interface information about the activity
to open, like the name or the icon.
This method allow get this information, previously only available on jarabe.

[1] http://wiki.sugarlabs.org/go/Features/Start_activity_from_another_activity
2015-07-03 15:03:27 -03:00
Martin Abente Lahaye
797130baed Release 0.105.3 2015-06-30 16:34:47 -04:00
Gonzalo Odiard
a873cfc04e Remove _HeaderSeparator
The palette using a Gtk.Menu, had a separator displayed using a custom widget,
but that was not well displayed (the line didn't had the palette width
due to margin on the palette) and was broken on Gtk >= 3.16
Instead of use that widget to draw the separator line between at the bottom
of _HeaderItem, as we do with the toolbar buttons when the palette is displayed.
2015-06-30 16:27:12 -04:00
tch
2ba05304f8 Commit from Sugar Labs by user tch.: 109 of 109 strings translated (0 need review). 2015-06-30 14:33:39 +00:00
Gonzalo Odiard
8af97e3e17 Replace use of deprecated icon_size by pixel_size
It's a trivial change, but the warning message was filling the logs.
2015-06-30 09:53:52 -04:00
Sam Parkinson
78dcd5a7e4 Fix GtkMenu palette positioning in Gtk 3.16 2015-06-29 13:53:19 -03:00
Gonzalo Odiard
9087eab839 Properly fix wrap mode on secondary text for toolbars
This patch solves a bug introduced on:
034706a482

Pep8 fix by Martin Abente Lahaye (reviewer).

Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
2015-06-23 12:04:45 -04:00
Martin Abente Lahaye
a3946f7c19 translations: add Guarani to LINGUAS
A group of kids from the OLPC project in Caacupe have translated both
the sugar shell and the sugar gtk3 toolkit to Guarani. They are also in
the process of translating sugar activities [1].

This patch add the gn entry to the LINGUAS file so the gn.po file can be
properly installed, as already is being done with the sugar shell.

[1] http://translate.sugarlabs.org/gn/

Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
2015-06-22 18:38:20 -04:00
tch
68058cf8a4 Commit from Sugar Labs by user tch.: 109 of 109 strings translated (0 need review). 2015-06-22 19:34:42 +00:00
Gonzalo Odiard
034706a482 Secondary text on palettes should respect the max width - Fixes #4862
When a activity have a title very long without spaces,
the text can't be wraped with the default wrap mode (WORD)
Use WRAP_CHAR to solve this issue.
2015-06-19 08:41:34 -03:00
Martin Abente Lahaye
5d0e06f07d Release 0.105.2 2015-06-01 09:10:14 -04:00
James Cameron
00c541af4f sugar-activity-web: remove bash specific code 2015-05-29 12:17:41 +10:00
Martin Abente Lahaye
e8553c13a1 Add skip-install-mime option to bundlebuilder
Historically, distro packagers have been using bunblebuilder, via
"setup.py install", to populate packages directories and files.

The install procedure uses ActivityBundle.install_mime_type to install
custom mime types, by creating symlinks and updating the system mime
types database via the update-mime-database tool.

When ActivityBundle.install_mime_type is executed during packages
creation, the symlinks end-up broken in the final package and the use
of update-mime-database populates the final packages with a new copy
of the database files which could clash with the system copy.

This patch adds a new option, called --skip-install-mime to "setup.py
install" to skip the execution of ActivityBundle.install_mime_type and
avoid the issues mentioned above.

Activity packagers should use this new option. The creation of symlinks
and the execution of update-mime-database should be done in post install
packaging steps.

Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
2015-05-28 16:30:04 -04:00
Gonzalo Odiard
fc4d629b50 TTS in the toolkit need initialize gstreamer - Fixes #4851
If is not initialized, the check for the espeak plugin will fail.
This patch also check for the espeak plugin at the beginnig
avoiding check every time the function enabled() is called.
2015-05-26 12:05:09 -04:00
James Cameron
4c22ba5b35 Add escape key to palette windows
Popdown a palette window in response to escape key.
2015-05-25 12:41:24 +10:00
Martin Abente Lahaye
9e34750ffd Release 0.105.1 2015-05-18 08:38:30 -04:00
Gonzalo Odiard
8224fefc50 Pep8 and pyflakes fixes 2015-05-16 19:13:34 +10:00
Gonzalo Odiard
2186c53aeb Palettes based in GtkMenu do not have present() method
There are two different palette widgets in Sugar.
_PaletteMenuWidget is a Gtk.Menu and  _PaletteWindowWidget is a Gtk.Window.
Only the palettes where the widget is a Gtk.Window can do present()
2015-05-16 19:13:34 +10:00
Gonzalo Odiard
5818721818 Merge branch 'treeview_perf2-try2' of https://github.com/godiard/sugar-toolkit-gtk3 into godiard-treeview_perf2-try2 2015-05-15 18:12:58 -03:00
Gonzalo Odiard
bbdebce0d4 Simplify routine used to get the list of files from git
This change remove duplicated code
2015-05-15 20:37:21 +10:00
Gonzalo Odiard
34b0e17e95 Add screenshots to ignored dirs in bundlebuilder
After add the directory to the IGNORE_DIRS array,
we need make the standard procedure to get the list off files
for the bundle, get_files_in_git honor the configured ignored
files and dirs. That was not a problem until now,
because that files was already not added to git,
but in the case of the screenshots, are included in git,
but we don't want include them in our bundles.
2015-05-15 20:37:21 +10:00